Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling ASA extension for AzSecPack #3220

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

suresh-thelkar
Copy link
Contributor

Disabling ASA extension for AzSecPack

@@ -123,7 +123,7 @@ def verify_azsecpack(self, node: Node, log: Logger, result: TestResult) -> None:
# Install agent extension
try:
self._install_monitor_agent_extension(node)
self._install_security_agent_extension(node, log)
# self._install_security_agent_extension(node, log)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please explain the reason to comment out it in the PR.
  2. Remove the line directly, instead of commenting out.

Copy link
Contributor Author

@suresh-thelkar suresh-thelkar Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to test a specific custom image. In order to run a pipeline I had to raise this PR and then use its GitHub reference in the pipeline. This is the reason I marked the PR as draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants