Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proposal for TreeView SelectionChanged event #80

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add proposal for TreeView SelectionChanged event #80

wants to merge 1 commit into from

Conversation

japf
Copy link

@japf japf commented Apr 7, 2020

Proposal for the SelectionChanged event that we added recently as preview in the WinUI repo: microsoft/microsoft-ui-xaml#2063

@japf japf requested a review from a team as a code owner April 7, 2020 08:13
@japf japf changed the title Add proposal for TreeView selection changed event Add proposal for TreeView SelectionChanged event Apr 7, 2020
marcelwgn
marcelwgn approved these changes Apr 7, 2020
View reviewed changes
active/TreeView/SelectionChangedEvent.md
Comment on lines +101 to +102
Windows.Foundation.Collections.IVector<Object> AddedItems{ get; };
Windows.Foundation.Collections.IVector<Object> RemovedItems{ get; };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SelectionModel class, in addition to SelectedItems also has SelectedItem. Maybe we could add that here too since we support single selection. On the other hand, we wouldn't gain much by adding that as you can also just get the item at index 0.

@japf
Copy link
Author

japf commented Aug 28, 2020

Closing this PR for now because of lack of interest.

@japf japf closed this Aug 28, 2020
@mrlacey
Copy link

mrlacey commented Aug 29, 2020

Closing this PR for now because of lack of interest.

How is interest measured?
What does this being closed mean for this proposal going forward? Will it never happen? Is it just moved to a low-priority backlog task?

@Felix-Dev
Copy link

I'm a bit surprised there has been no progress here. @ranjeshj @MikeHillberg FYI.

@japf
Copy link
Author

japf commented Aug 31, 2020

How is interest measured?

Actually this was probably poorly written, sorry about that.
What I meant is that there was no traction on this proposal and that i cannot commit more time on this at the moment.

@ranjeshj
Copy link

ranjeshj commented Sep 1, 2020

Adding @predavid-zz to see if she can help with the spec. @japf Thanks for adding the API to preview.

@japf japf reopened this Sep 3, 2020
@adambarlow adambarlow requested review from predavid-zz and removed request for a team September 3, 2020 18:31
@Felix-Dev Felix-Dev mentioned this pull request Sep 24, 2020
Merged
@Felix-Dev Felix-Dev mentioned this pull request Nov 3, 2020
Closed
@Felix-Dev Felix-Dev mentioned this pull request Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwgn marcelwgn marcelwgn approved these changes

@predavid-zz predavid-zz Awaiting requested review from predavid-zz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@japf @mrlacey @Felix-Dev @ranjeshj @marcelwgn