Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User/savoyschuler/pagercontrol #88
base: master
Are you sure you want to change the base?
User/savoyschuler/pagercontrol #88
Changes from 19 commits
9526410
06eb0d1
7a2c5ef
f374490
8a700a6
bcbd98a
37cfe57
c59b0d5
e7cac61
eb8d93b
6ca1d2a
7bea33c
daacb33
2bd81a6
7d1b6ba
f3382f4
3193a6c
ab66a9d
60cb6a1
9a2fa2a
737f5a1
e198965
131e96e
4c1b015
9b7df8d
a6fe102
1bf8d1d
2ab8c61
9e5b9fc
5b740b7
d24b663
5342ef0
b369b49
fabb49f
45b0fd6
8d36d41
e927765
9f91751
00b7236
71aa153
2434231
12af7ee
eafc9a8
057b93d
cf22121
79ecc16
99848d2
ba0cea8
124615c
6615ca5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can delete all these comments from the template
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use "PagerControl" when we're talking about the control, and "pager control" when we're talking about the abstract UI concept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks more like IDL than C++.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MikeHillberg I was following the template for this section. Is there something I should update this to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically only for GitHub (and other MarkDown render engines) to know what syntax highlighting to use, but it also helps when reading the raw md file to know what language this is written in. If the API details are in (M)IDL format, this should be IDL. I'm a bit surprised that C++ is in the template, usually APIs are done in IDL as we can simply copy paste that into the actual WinUI source code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's following the template, except that it needs to be IDL. Changing this to Int32 might be the only issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how that snuck in, but now we have two lines defining the PagerControl class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.