-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject non-DER ASN.1 encodings #85
base: main
Are you sure you want to change the base?
Conversation
This rejects several ASN.1 encodings that are not valid DER. Some more care may be needed in the case of BIT STRINGs. It also fixes an integer overflow (not exploitable).
@DemiMarie please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
The buffer size is limited to INT16_MAX, but the code should not depend on this. Instead, check for overflow explicitly.
@microsoft-github-policy-service agree |
This rejects several ASN.1 encodings that are not valid DER. Some more care may be needed in the case of BIT STRINGs. It also fixes an integer overflow (not exploitable).