-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependency for libxdp/libbpf #4234
Conversation
.docker/ubuntu-20.04/Dockerfile
Outdated
@@ -39,6 +40,17 @@ RUN apt-get update && apt-get install --no-install-recommends -y apt-transport-h | |||
cppcheck \ | |||
clang-tidy \ | |||
gdb \ | |||
libxdp-dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mentioned in our teams call today that some packages were old versions. Do these have the versions you need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apt-add-repository "deb http://mirrors.kernel.org/ubuntu noble main"
I found this repository having 1.4.0. works on Ubuntu 22.04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by default there is no libxdp package at all. there is only libbpf 0.5 or so (ubuntu 22.04)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xdp-tools seems to be not providing binary.
xdp-project/xdp-tools#416
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4234 +/- ##
==========================================
- Coverage 85.69% 85.20% -0.49%
==========================================
Files 56 56
Lines 15359 15359
==========================================
- Hits 13162 13087 -75
- Misses 2197 2272 +75 ☔ View full report in Codecov by Sentry. |
Looks like the tasks failed |
libxdp/libbpf (for amd64) and libcrypt1 (arm) conflicts libc6 version..... |
Description
Remove dependency to xdp-tools. install libxdp/libbpf headers instead.
Testing
N/A
Documentation
N/A