Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency for libxdp/libbpf #4234

Merged
merged 4 commits into from
Apr 10, 2024
Merged

Conversation

ami-GS
Copy link
Contributor

@ami-GS ami-GS commented Apr 9, 2024

Description

Remove dependency to xdp-tools. install libxdp/libbpf headers instead.

Testing

N/A

Documentation

N/A

@ami-GS ami-GS requested a review from a team as a code owner April 9, 2024 23:10
@@ -39,6 +40,17 @@ RUN apt-get update && apt-get install --no-install-recommends -y apt-transport-h
cppcheck \
clang-tidy \
gdb \
libxdp-dev \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mentioned in our teams call today that some packages were old versions. Do these have the versions you need?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apt-add-repository "deb http://mirrors.kernel.org/ubuntu noble main"
I found this repository having 1.4.0. works on Ubuntu 22.04

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default there is no libxdp package at all. there is only libbpf 0.5 or so (ubuntu 22.04)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xdp-tools seems to be not providing binary.
xdp-project/xdp-tools#416

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.20%. Comparing base (6abfbec) to head (f8e9ead).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4234      +/-   ##
==========================================
- Coverage   85.69%   85.20%   -0.49%     
==========================================
  Files          56       56              
  Lines       15359    15359              
==========================================
- Hits        13162    13087      -75     
- Misses       2197     2272      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nibanks
nibanks previously approved these changes Apr 10, 2024
@nibanks
Copy link
Member

nibanks commented Apr 10, 2024

Looks like the tasks failed

@nibanks nibanks dismissed their stale review April 10, 2024 00:25

Failed

@ami-GS
Copy link
Contributor Author

ami-GS commented Apr 10, 2024

libxdp/libbpf (for amd64) and libcrypt1 (arm) conflicts libc6 version.....
struggling with installing for each arch, not sure it is possible

@ami-GS ami-GS merged commit 2602a20 into main Apr 10, 2024
348 of 352 checks passed
@ami-GS ami-GS deleted the dev/daiki/xdp_remove_xdptool_dep branch April 10, 2024 21:33
ami-GS added a commit that referenced this pull request Apr 11, 2024
nibanks pushed a commit that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants