Update Execution Docs #4640
Merged
Update Execution Docs #4640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4640 +/- ##
==========================================
- Coverage 87.27% 86.78% -0.49%
==========================================
Files 56 56
Lines 17354 17354
==========================================
- Hits 15145 15061 -84
- Misses 2209 2293 +84 ☔ View full report in Codecov by Sentry. |
mtfriesen
reviewed
Nov 4, 2024
mtfriesen
reviewed
Nov 4, 2024
mtfriesen
reviewed
Nov 4, 2024
mtfriesen
reviewed
Nov 4, 2024
mtfriesen
reviewed
Nov 4, 2024
mtfriesen
reviewed
Nov 4, 2024
mtfriesen
reviewed
Nov 4, 2024
mtfriesen
reviewed
Nov 4, 2024
ami-GS
reviewed
Nov 4, 2024
| ``` | ||
|
|
||
| Above is an example of a callback delivered to the listener interface. | ||
| The application must register a per-object callback handler to manage all events MsQuic may indicate for that object, returning a status to show if it was successfully handled or not. |
There was a problem hiding this comment.
How about emphasizing "must" like MUST used in RFC? MUST MAY REQUIRD etc.
There was a problem hiding this comment.
I just checked and we have a LOT of musts that we don't do that for throughout the docs. Let's push that to a separate, follow up PR. Ok?
mtfriesen
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This revamps our documentation on MsQuic's execution mode, including how we manage callbacks and threads.
Testing
N/A
Documentation
Updated