Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winkernel to use xdp datapath #4654

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

Conversation

ami-GS
Copy link
Contributor

@ami-GS ami-GS commented Nov 13, 2024

Description

built with placeholders

Testing

N/A

Documentation

N/A

@ami-GS ami-GS requested a review from a team as a code owner November 13, 2024 19:11
Base automatically changed from dev/daiki/winkernel_merging to main November 22, 2024 17:07
@ami-GS ami-GS changed the title Dev/daiki/winkernel merging exp Winkernel to use xdp datapath Nov 25, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.58%. Comparing base (21e5b41) to head (6cd0fee).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4654      +/-   ##
==========================================
- Coverage   87.05%   86.58%   -0.48%     
==========================================
  Files          56       56              
  Lines       17361    17363       +2     
==========================================
- Hits        15114    15033      -81     
- Misses       2247     2330      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ami-GS ami-GS force-pushed the dev/daiki/winkernel_merging_exp branch from f3856b7 to 945d71f Compare November 27, 2024 21:47
@ami-GS ami-GS force-pushed the dev/daiki/winkernel_merging_exp branch from 945d71f to 6c1b53c Compare November 27, 2024 21:59
@ProjectsByJackHe
Copy link
Contributor

Before merging this PR, let's make sure Netperf doesn't break.

@ami-GS ami-GS force-pushed the dev/daiki/winkernel_merging_exp branch from 9e22821 to 2766546 Compare December 10, 2024 23:33
@ami-GS
Copy link
Contributor Author

ami-GS commented Dec 11, 2024

Tests succeed, but trace says there are many XDP async IO start, but there is no completion (RawDataPathProcessCqe) at all.

@ami-GS
Copy link
Contributor Author

ami-GS commented Dec 11, 2024

Maybe CxPlatXdpExecute should call XskNotifyAsync, not ZwSetInformationFile. However doing it gets error as

image

@ami-GS
Copy link
Contributor Author

ami-GS commented Dec 11, 2024

Sometimes passes with few XDP async IO start calls

@ami-GS
Copy link
Contributor Author

ami-GS commented Dec 13, 2024

Maybe CxPlatXdpExecute should call XskNotifyAsync, not ZwSetInformationFile. However doing it gets error as

image

This was due to handling kernel mode error as user mode error. both are for PENDING

@ami-GS ami-GS force-pushed the dev/daiki/winkernel_merging_exp branch from 57ba0a0 to 6cd0fee Compare December 13, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants