Cherry picks Delegate build and export platform #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…microsoft#4625) Well managed CMake build environments make use of CMAKE_TOOLCHAIN_FILE to configure build environment such as include/lib search paths, system libraries, build flags, etc. This change introduces QUIC_EXTERNAL_TOOLCHAIN build option, which when enabled stops MSQuic CMake scripts from attempting to do CMake toolchain job. QUIC_EXTERNAL_TOOLCHAIN defaults to OFF to preserve original behaviour.
This was referenced Dec 4, 2024
Closed
nibanks
reviewed
Dec 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2.4 #4685 +/- ##
===============================================
+ Coverage 85.99% 86.82% +0.83%
===============================================
Files 56 56
Lines 17338 17338
===============================================
+ Hits 14909 15053 +144
+ Misses 2429 2285 -144 ☔ View full report in Codecov by Sentry. |
talregev
force-pushed
the
TalR/release/2.4/delegate_build_export_platform
branch
from
31f11f4 to
d64952c
Compare
|
@nibanks I change the last commit to be the cherry pick from main. |
nibanks
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks Delegate build and export platform