Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict MaxOperationsPerDrain to Greater Than Zero #4706

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Dec 12, 2024

Description

Fixes #4705 by disallowing the app to set a value of zero.

Testing

Added

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner December 12, 2024 13:21
@nibanks nibanks linked an issue Dec 12, 2024 that may be closed by this pull request
4 tasks
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.55%. Comparing base (21e5b41) to head (c4b51ce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4706      +/-   ##
==========================================
- Coverage   87.05%   86.55%   -0.50%     
==========================================
  Files          56       56              
  Lines       17361    17363       +2     
==========================================
- Hits        15114    15029      -85     
- Misses       2247     2334      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@guhetier guhetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the documentation be updated to mention that zero is not a valid value?

@nibanks nibanks merged commit d337a3c into main Dec 12, 2024
479 of 481 checks passed
@nibanks nibanks deleted the limit-maxoperationsperdrain branch December 12, 2024 15:30
@nibanks
Copy link
Member Author

nibanks commented Dec 12, 2024

Should the documentation be updated to mention that zero is not a valid value?

Nah, I don't think it's really necessary. Zero is fundamentally a bad value. That's essentially saying the max work you're allowed to do is nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set MaxOperationsPerDrain to 0 causes worker thread busy spinning
3 participants