-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpellCheck Plugin: Supporting dictionary files #1161
base: dev/202405
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1161 +/- ##
===========================================
Coverage 1.59% 1.59%
===========================================
Files 1448 1448
Lines 362491 362491
Branches 5632 5632
===========================================
Hits 5776 5776
Misses 356608 356608
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Should this go up to edk2 first? |
I think so. |
@bkarstens, can you please make a PR for these changes in edk2? When that is completed, you can update this PR to be a cherry-pick of that commit. |
Here's the PR: tianocore/edk2#6238 |
This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Description
Added support for dictionary files to the
SpellCheck
plugin. This separates extra words from actual configuration, and allows for integration with othercspell
plugins like vscode's Code Spell Checker plugin.Readme.md
.How This Was Tested
Ran
stuart_ci_build
on a platform with the words moved to a dictionary file. Compared the generatedcspell_actual_config.json
to a version generated before moving the words: contents matched.Integration Instructions
Optional: In places lots of words are in the
ExtendWords
config, move words to dictionary file and add the workspace-relative path to theExtraDictionaries
config.