Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Commit

Permalink
Revert "Update packaging of LibFuzzerDotNetLoader (#3248)" (#3327)
Browse files Browse the repository at this point in the history
This reverts commit 25f1257.

The change broke the libfuzzer dotnet template (I could have sworn I validated first with check-pr but…)

Two things didn't work:
1. the path to the LibFuzzerDotNetLoader needed to change; I attempted to fix this in #3324 
2. minidumps weren't being captured, for an unknown reason. I haven't figured out why yet, thus I'm going to simply revert the change so we have this working for the next release.
  • Loading branch information
Porges authored Jul 24, 2023
1 parent 33e645d commit e68fc45
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
6 changes: 0 additions & 6 deletions src/agent/LibFuzzerDotnetLoader/LibFuzzerDotnetLoader.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@
<TargetFramework>net7.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<!-- make published binaries as small as possible -->
<SelfContained>true</SelfContained>
<PublishSingleFile>true</PublishSingleFile>
<InvariantGlobalization>true</InvariantGlobalization>
<DebuggerSupport>false</DebuggerSupport>
<!-- /end -->
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/ci/dotnet-fuzzing-tools.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ popd

# Build SharpFuzz and our dynamic loader harness for `libfuzzer-dotnet`.
pushd src/agent/LibFuzzerDotnetLoader
dotnet publish . -c Release -o $ARTIFACTS/LibFuzzerDotnetLoader -r win10-x64
dotnet publish . -c Release -o $ARTIFACTS/LibFuzzerDotnetLoader --sc -r win10-x64
if ($LASTEXITCODE -ne 0) { throw "dotnet publish exited with $LASTEXITCODE" }
popd

Expand Down
2 changes: 1 addition & 1 deletion src/ci/dotnet-fuzzing-tools.sh
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ popd

# Build SharpFuzz and our dynamic loader harness for `libfuzzer-dotnet`.
pushd src/agent/LibFuzzerDotnetLoader
dotnet publish . -c Release -o $ARTIFACTS/LibFuzzerDotnetLoader -r linux-x64
dotnet publish . -c Release -o $ARTIFACTS/LibFuzzerDotnetLoader --sc -r linux-x64
popd

# Build `libfuzzer-dotnet`.
Expand Down

0 comments on commit e68fc45

Please sign in to comment.