This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Add snapshot test support for coverage implementation #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3368 +/- ##
==========================================
+ Coverage 32.21% 34.70% +2.48%
==========================================
Files 302 302
Lines 36931 36917 -14
==========================================
+ Hits 11897 12811 +914
+ Misses 25034 24106 -928
|
Porges
changed the title
Srcview binary test
Add snapshot test support for coverage implementation
Aug 1, 2023
ranweiler
approved these changes
Aug 2, 2023
chkeita
approved these changes
Aug 8, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test forsrcview
that exercises it against a real executable, as prep for #3362. This also adds test coverage for a lot of code we didn't have covered before.Add a snapshot-based test to our coverage implementation. This adds coverage for a bunch of code which did not previously have it, and allows us to easily see that coverage is being generated as expected.
A fix was made to the recording code to remove the use of
TargetAllowList
as it was easy to misconfigureCoverageRecorder
when using it. The use ofTargetAllowList
is now only a container struct in our generic coverage task.