chore: introduce asyncio mode #184
Conversation
mxschmitt
force-pushed
the
pytest-async
branch
from
3eec557
to
ffbd3e9
Compare
|
Just a recap of this issue and why we don't proceed: Ideally we can have sync and async in the same repository and based on if a test file is marked as sync, it uses the sync fixtures or its async and it uses the async Playwright fixtures. So far I didn't find a great way of doing that Pytest wise. |
There was a problem hiding this comment.
There is pytest_asyncio.is_async_test which may be helpful to you: https://github.com/pytest-dev/pytest-asyncio/blob/v0.23.3/pytest_asyncio/plugin.py#L988-L990
|
|
||
|
|
||
| def pytest_configure(config: pytest.Config) -> None: | ||
| if (config.getini("playwright_pytest_asyncio") is None and config.pluginmanager.hasplugin("asyncio")) or config.getini("playwright_pytest_asyncio"): |
There was a problem hiding this comment.
To share, I have seen others using AnyIO for async testing: https://anyio.readthedocs.io/en/1.4.0/testing.html
It might be good to account for other async plugins that can trigger registration of PytestPlaywrightAsyncio
This uses async fixtures if the
pytest-asyncioplugin is loaded, we might should harden this condition more, since there might be projects where thepytest-asyncioplugin is loaded but the users wants sync fixtures.Also all the tests got mirrored, changed to the asyncio way of doing this except two UnitTest tests, which are not supported with pytest-asyncio see here.
Ref: https://docs.pytest.org/en/7.1.x/how-to/writing_hook_functions.html#optionally-using-hooks-from-3rd-party-plugins
#74
Edit: Ideally we can have sync/async on a folder level.