feat(run-server): expose --host #28723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Dec 19, 2023
| const address = server.address(); | ||
| if (!address) { | ||
| reject(new Error('Could not bind server socket')); | ||
| return; | ||
| } | ||
| const wsEndpoint = typeof address === 'string' ? `${address}${this._options.path}` : `ws://127.0.0.1:${address.port}${this._options.path}`; | ||
| const wsEndpoint = typeof address === 'string' ? `${address}${this._options.path}` : `ws://${hostname}:${address.port}${this._options.path}`; |
There was a problem hiding this comment.
Note: We could use address.address there which would be more appropriate, but it results in ws://::1:3000/ instead of what the user expects ws://localhost:3000/.
This is aligned with e.g. what we do in HTML report.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"4 flaky21180 passed, 585 skipped Merge workflow run. |
pavelfeldman
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.