fix(codegen): fix unselect issue #32127
Conversation
| if (withCtrl) { | ||
| await page.keyboard.down("Control"); | ||
| } | ||
| await page.mouse.click(rect.x + rect.width / 2, rect.y + rect.height / 2); |
There was a problem hiding this comment.
While investigating test failure on webkit, I noticed locator.click for multiple select option doesn't work.
I think it's another problem so I've created an issue
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| // Webkit can't click multiple select options | ||
| // https://github.com/microsoft/playwright/issues/32126 | ||
| if (page.context().browser().browserType().name() === 'webkit') { | ||
| const elem = await locator.elementHandle(); |
There was a problem hiding this comment.
element handles are discouraged, there is a way to get bounding box from locator in one line.
There was a problem hiding this comment.
boundingBox returns null as it's assumed as not visible. That's why I use eval thing here
|
|
||
| const locator = await recorder.hoverOverElement('select'); | ||
| expect(locator).toBe(`locator('#age')`); | ||
| await clickMultipleSelectOption(page.getByRole('option', { name: '1' })); |
There was a problem hiding this comment.
I hope clicking the select instead of option with offset to pick an element would work across the browsers.
There was a problem hiding this comment.
@pavelfeldman
Um, I'm not sure what kind of operation you're referring to. Could you show me a code example?
This comment has been minimized.
This comment has been minimized.
mtsmfm
force-pushed
the
fix-unselect
branch
from
a9d489f
to
ad89bd2
Compare
Test results for "tests 1"2 flaky36432 passed, 758 skipped Merge workflow run. |
Fixes #31290