Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-mode): prevent websocket connection leaks on reload #33643

Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix(ui-mode): prevent websocket connection leaks on reload #33643

merged 1 commit into from
Nov 18, 2024

Conversation

ruifigueira
Copy link
Contributor

Fixes: #33641

@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

1 flaky ⚠️ [chromium-library] › library/chromium/oopif.spec.ts:284:3 › should click @chromium-ubuntu-22.04-node18

36917 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

@ruifigueira
Copy link
Contributor Author

Failing on embedded-trace-viewer tests, that must be karma 😞 But apparently they have been failing for a couple of days, so it seems unrelated.

dgozman
dgozman approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the PR!

@dgozman dgozman merged commit 82c77a5 into microsoft:main Nov 18, 2024
28 of 29 checks passed
@ruifigueira ruifigueira mentioned this pull request Nov 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: WebSocket leakage in UI Mode
2 participants
@ruifigueira @dgozman