-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve merge token logic to account for nested dicts #3825
Conversation
@microsoft-github-policy-service agree |
this might solve issues - #3834 and #3806
using promptflow==1.16.1 and openai ==1.44.1 |
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
SDK CLI Global Config Test Result fix/merge-tokens0 tests 0 ✅ 0s ⏱️ Results for commit 8727276. |
Executor E2E Test Result fix/merge-tokens0 tests 0 ✅ 0s ⏱️ Results for commit 8727276. |
Executor Unit Test Result fix/merge-tokens0 tests 0 ✅ 0s ⏱️ Results for commit 8727276. |
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
Due to the lack of this patch, Promptflow fails to run recent LLMs that include prompt caching features, which replace integer tokens with dictionaries, among potentially many other issues. Although the project seems to be paused, I hope Promptflow can be maintained since it is one of the largest libraries with the most stars on orchestrating LLMs, even Langflow only support Mac in GUI. |
Hello and thank you for your great work. |
Description
This PR fixes #3806 as it appears the the tokens object may contain nested objects. Added a function to handle merging nested dicts
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines