Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to v7 #303

Merged
merged 21 commits into from
Aug 28, 2024
Merged

Upgrade to v7 #303

merged 21 commits into from
Aug 28, 2024

Conversation

Amerlander
Copy link
Collaborator

@Amerlander Amerlander commented Aug 20, 2024 •
edited
Loading

This PR upstreams with MakeCode Microbit 7.0.21 and is meant to be releases as alpha for first testings.

@Amerlander
Copy link
Collaborator Author

@abchatra This PR introduces version 7. Can you create us a v6 branch and pin the current stable to the latest v6, so we can safely merge this PR and start working on v7?

Amerlander
Amerlander commented Aug 22, 2024
View reviewed changes
Copy link
Collaborator Author

@Amerlander Amerlander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I comented on files, that need our attention

docs/extensions/extension-gallery.md Outdated Show resolved Hide resolved
docs/static/extensions/extensions-window.gif Show resolved Hide resolved
docs/static/teachertool/add-criteria.png Outdated Show resolved Hide resolved
docs/teachertool/carousels/checklists-for-games/cards.json Outdated Show resolved Hide resolved
libs/core/blocks-test/test.blocks Outdated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test seemed corrupt, therefore I removed it for now. We should reimplement a new one.

@abchatra
Copy link
Contributor

@abchatra This PR introduces version 7. Can you create us a v6 branch and pin the current stable to the latest v6, so we can safely merge this PR and start working on v7?

I have created v6 branch. Can you elaborate on stable pointing to the latest v6? Do you mean beta-ref.json or alpha-ref.json? I don't see a stable-ref.json

@Amerlander
Copy link
Collaborator Author

Can you elaborate on stable pointing to the latest v6? Do you mean beta-ref.json or alpha-ref.json? I don't see a stable-ref.json

Thank you! I meant index-ref.json with stable, which actually does point to the latest v6 so it should be fine as it is.

@Amerlander Amerlander marked this pull request as ready for review August 28, 2024 16:12
@Amerlander
Copy link
Collaborator Author

@abchatra can you merge this PR and create a release tag vor v7, so we can test it in our alpha-ref (which has "appref": "v")?

@abchatra abchatra merged commit 29c3075 into microsoft:master Aug 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amerlander @abchatra