Fixed set mode of raw reflection values (mode numbered zero) in simulator for nxt light sensor #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we find the DAL.CONN_NXT_DUMB sensor, we additionally call setAnalogMode(), which passes the sensor mode to the simulator. Perhaps the same thing needs to be done for DAL.CONN_INPUT_DUMB, but there is only one analog sensor ev3 (touch sensor), and it works without this change.
THEb0nny
changed the title
2024-02-04_09-28-12.mp4 |
2024-02-04_09-32-45.mp4 |
THEb0nny
changed the title
|
@jwunderl you may want to consider this bugfix to the previous change. I initially forgot that there was such a problem, now I have fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _setMode() method was called, and just like at the beginning of this.mode = 0, this.realmode = 0, the algorithm in _setMode checks this.realmode != this.mode and only then calls setAnalogMode(), in which the mode is passed to the simulator.
When we find the DAL.CONN_NXT_DUMB sensor in detectDevices(), we additionally call setAnalogMode(). Perhaps the same thing needs to be done for DAL.CONN_INPUT_DUMB, but there is only one analog sensor ev3 (touch sensor), and it works without this change. This way you set the mode forcibly when the sensor is found, i.e. at the beginning.
I did the same thing as when finding DAL.CONN_INPUT_UART, in that case updateUartMode() is called.