Add support non-English words in docstring arguments #6307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rchiodo
approved these changes
Nov 2, 2023
This comment has been minimized.
This comment has been minimized.
debonte
approved these changes
Nov 2, 2023
This comment has been minimized.
This comment has been minimized.
|
@bschnurr, looks like the tests are failing for this PR. If you'd like to get this into this week's pyright release, please fix the tests and merge the PR. |
|
hi @erictraut maybe the regex can be cause it seems not that important to match the content to right of the |
|
Do we have any updates here? Maybe I can open a new PR if this PR doesn't progress anymore. |
|
@bschnurr, any update on this PR? |
…ict with invalid types in the google doc style with invalid types.
This comment has been minimized.
This comment has been minimized.
bschnurr
commented
Nov 15, 2023
| @@ -746,31 +746,6 @@ Returns: | |||
| _testConvertToMarkdown(docstring, markdown); | |||
| }); | |||
|
|
|||
| test('GoogleWithInvalidTypes', () => { | |||
There was a problem hiding this comment.
Now that are regex is very relaxed we are keeping the line break in this example. so its no longer a failure case.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
done |
|
thank you guys very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes microsoft/pylance-release#4615