-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class constraints for built-in classes #2005
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezna
requested review from
idavis,
minestarks,
swernli,
billti,
cesarzc,
DmitryVasilevsky,
tcNickolas and
ScottCarda-MS
as code owners
November 5, 2024 20:06
Change in memory usage detected by benchmark. Memory Report for f387f6f
|
Change in memory usage detected by benchmark. Memory Report for 81431fb
|
swernli
reviewed
Nov 5, 2024
Change in memory usage detected by benchmark. Memory Report for 756cbab
|
I opened #2007 to replace this, since there are too many commits and it is hiding comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes some relevant built-in classes via class constraints.
Changes
TypeParameter
,ClassConstraint
, andConstraintParameter
AST nodes to represent the notion of a generic type that might have class constraints, and constraints that may have parameters (e.g.Exp[Int]
).Ty
can now contain arbitrary constraintsfn constrained_ty
)tiny changes:
Ty
andTyParam
, for example)MissingTy
(it mentioned something about global types not being inferred when 99% of the time it does not apply to a global type, it applies to a callable parameter with a missing type)TODO for this PR
I did not want to block reviewing this PR on this bug, since it isn't an experience breaker, but I would like to get it resolved before this goes in. Sometimes, multiple errors are rendered, and I've narrowed it down to duplicate constraints getting generated. I could store constraints in some sort of
Set
, so they're deduplicated, but I'd rather figure out what we are repeatedly visiting to generate those constraints instead of deduplicating afterwards. I'll be tracking this down while the PR is reviewed.