Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Homepage to Not Display Images on Mobile #940

Merged
merged 2 commits into from
May 20, 2024

Conversation

chiaramooney
Copy link
Collaborator

@chiaramooney chiaramooney commented May 17, 2024

Description

Why

Edit homepage to not display images when webpage is being viewed on mobile. 'Prettier' was run on the source code creating more changes. Only changes to index.js were to add the new HomePageImage class to the image's that should not be displayed on mobile.

BEFORE

image

AFTER

image
Microsoft Reviewers: Open in CodeFlow

@chiaramooney chiaramooney requested a review from a team as a code owner May 17, 2024 17:46
Copy link
Contributor

@TatianaKapos TatianaKapos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisglein
Copy link
Member

@chiaramooney Can we get some before after screen captures? Both desktop/wide screen vs. mobile or narrow screen.

chiaramooney added a commit that referenced this pull request May 20, 2024
## Description

### Why
Separates linting changes from
#940 into
a separate PR.

###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/react-native-windows-samples/pull/941)
@chiaramooney chiaramooney merged commit ff7bdd1 into microsoft:main May 20, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants