Adding the cheriot-audit tests to the test suite #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
mjp41
reviewed
Jun 6, 2024
| @@ -0,0 +1,181 @@ | |||
| #include "../rego_test.h" | |||
There was a problem hiding this comment.
Has this code come from cheriot? Do we need some attribution here?
There was a problem hiding this comment.
This is our SPDX header:
// Copyright SCI Semiconductor and CHERIoT Contributors.
// SPDX-License-Identifier: MIT
| return scalar(false); | ||
| } | ||
| string = string.substr(1); | ||
| // The way that rego-cpp exposes snmalloc can cause the realloc here to |
There was a problem hiding this comment.
Aiming to fix this with microsoft/Trieste#117
I'm talking with David about options. I think we're going to change the tactic to include his repo and and build it against the current repo/branch similar to how we do with Python and Rust, instead of manually copying it in as I've done. He needs to do a bit of instrumentation first, but that way we don't have duplication. |
|
CHERIoT-Platform/cheriot-audit#4 should make that option easier. |
|
This has been done via another means. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the test suite from https://github.com/CHERIoT-Platform/cheriot-audit/ to this repo.