fix(build): bump @octokit/core to 5.x
#2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tido64
force-pushed
the
tido/build/node-18-only
branch
from
b00f801 to
6ae007b
Compare
BREAKING CHANGE: `@octokit/core` 5.0.0 drops support for Node 14 and 16. Testing shows that at least Node 16 still works if you import `node-fetch`, so technically, if your setup does not enforce Node version, you can still use this package.
tido64
force-pushed
the
tido/build/node-18-only
branch
from
6ae007b to
b297d96
Compare
kelset
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE:
@octokit/core5.0.0 drops support for Node 14 and 16.Testing shows that at least Node 16 still works if you import
node-fetch, so technically, if your setup does not enforce Node version, you can still use this package.Test plan
cd incubator/build yarn build --dependencies yarn rnx-build -p ios --device-type simulator ../../packages/test-app