-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webapis): introduce @react-native-webapis/battery-status
#2590
Conversation
dc90512
to
9f50b41
Compare
ca31571
to
6d24a06
Compare
0a3f7e0
to
5bb88c9
Compare
incubator/@react-native-webapis/battery-status/android/build.gradle
Outdated
Show resolved
Hide resolved
incubator/@react-native-webapis/battery-status/android/build.gradle
Outdated
Show resolved
Hide resolved
5bb88c9
to
96efd68
Compare
is fast refresh something that can be tested by the e2e tester in CI, to capture the problem fixed in the polyfill? |
1d25503
to
0e050fb
Compare
I've added tests, but it doesn't look like we're capable of capturing this specific error. We currently don't have e2e tests running on a device (emulator or otherwise). I'm not sure how one would trigger fast refresh outside of running the code. If you have any pointers, I'd really appreciate it. |
17079a3
to
46b7e5b
Compare
ddd7404
to
f65d01d
Compare
cafc35e
to
0f7449f
Compare
0f7449f
to
3618b4a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall it all looks great. This PR showcases already some learnings and standards/patterns that we should codify back into the RFC, I'll take care of that.
Thanks for all the work 🙇♂️
Description
Initial implementation of Battery Status API for Android, iOS, macOS, and Windows.
Requires #2580.
Test plan
Apply the following changes to the test app:
Build and run:
Note: When running in the iOS simulator, the battery level will always be '-1'.
Screenshots