-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(webapis): add tool for scanning for uses of Web APIs #2621
Conversation
cd2ade6
to
3c62c55
Compare
89ae55f
to
dd05be1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for working on this!
I love that by going down the Rust route, the tool is blazing fast ⚡️
I left a few comment; aside from those, can we add a README.md to the root of scan that explains:
- how to use it/build it
- what the merge.mjs file is
- what is the counting logic (if I read correctly, we count all instances across all files we find minus the ones in the ignored_dirs?)
dd05be1
to
d98f0ca
Compare
d98f0ca
to
b2b7fa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for addressing the feedback!
Description
Implemented a tool for scanning for uses of Web APIs.
Test plan