Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundle size log even when metafile is set #2687

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

AAHAbbas
Copy link
Contributor

Description

Log esbuild bundle size even when the esbuild metafile option is set.

Test plan

Prepare:

cd packages/test-app
yarn build --dependencies

Bundle size should be logged:

diff --git a/packages/test-app/package.json b/packages/test-app/package.json
index bf87fe69..64b62c32 100644
--- a/packages/test-app/package.json
+++ b/packages/test-app/package.json
@@ -118,7 +118,9 @@
         "id": "esbuild",
         "entryFile": "src/index.ts",
         "assetsDest": "dist",
-        "treeShake": true,
+        "treeShake": {
+          "metafile": "meta.json"
+        },
         "plugins": [
           "@rnx-kit/metro-plugin-cyclic-dependencies-detector",
           [

@AAHAbbas AAHAbbas changed the title Abbas/add bundle size log Add bundle size log even when metafile is set Sep 18, 2023
@tido64 tido64 merged commit 52e032e into microsoft:main Sep 18, 2023
12 checks passed
@AAHAbbas AAHAbbas deleted the abbas/AddBundleSizeLog branch September 18, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants