fix(eslint-plugin): cache access to `NODE_ENV` #2693

tido64 · 2023-09-21T08:50:46Z

Description

Cache access to NODE_ENV. process.env is apparently a special object and is slow to access. We don't expect NODE_ENV to change here, so we should cache it.

Test plan

n/a

kelset

I don't even know how you managed to figure this one out but

tido64 · 2023-09-21T08:56:43Z

I don't even know how you managed to figure this one out but

😅 Someone else did the work: jestjs/jest#14455

fix(eslint-plugin): cache access to NODE_ENV

9d08143

tido64 requested review from kelset and JasonVMo as code owners September 21, 2023 08:50

github-actions bot added the feature: eslint This is related to ESLint label Sep 21, 2023

kelset approved these changes Sep 21, 2023

View reviewed changes

tido64 enabled auto-merge (squash) September 21, 2023 08:57

tido64 merged commit a442ffd into main Sep 21, 2023
12 checks passed

tido64 deleted the tido/eslint-plugin/cache-node-env branch September 21, 2023 09:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): cache access to `NODE_ENV` #2693

fix(eslint-plugin): cache access to `NODE_ENV` #2693

tido64 commented Sep 21, 2023

kelset left a comment

tido64 commented Sep 21, 2023

fix(eslint-plugin): cache access to NODE_ENV #2693

fix(eslint-plugin): cache access to NODE_ENV #2693

Conversation

tido64 commented Sep 21, 2023

Description

Test plan

kelset left a comment

Choose a reason for hiding this comment

tido64 commented Sep 21, 2023

fix(eslint-plugin): cache access to `NODE_ENV` #2693

fix(eslint-plugin): cache access to `NODE_ENV` #2693