Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test-app): reconfigure so our babel.config.js gets picked #2698

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Sep 22, 2023

Description

Metro looks for a Babel config in projectRoot, which is currently set to ./src. Created a root index.js that imports ./src/index and removed projectRoot from server config.

Test plan

cd packages/test-app
yarn build --dependencies
yarn start

# In a separate terminal
curl -v 'http://localhost:8081/index.bundle?platform=ios'

@tido64 tido64 enabled auto-merge (squash) September 22, 2023 13:26
Copy link
Contributor

@kelset kelset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works

@tido64 tido64 merged commit 6f61125 into main Sep 22, 2023
12 checks passed
@tido64 tido64 deleted the tido/fix-test-app branch September 22, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants