-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass minify CLI option to metro-serializer-esbuild #2722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. I think we want to avoid having two minify
options inside BundleParameters
. See the comment below.
5b89e48
to
b59d455
Compare
b59d455
to
6843675
Compare
6843675
to
650ed34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now. I left a couple of nits.
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Co-authored-by: Tommy Nguyen <4123478+tido64@users.noreply.github.com>
Thanks again 👍 |
Description
Running
yarn react-native rnx-bundle --dev false --minify false
doesn't generate a prod bundle that's not minified. Passing theminify
CLI option to themetro-serializer-esbuild
so the outputted bundle will be minified or not depending on the passed minify flag.Test plan
Prepare:
Generating a prod bundle that's minified:
Generating a prod bundle that's not minified (this would still generate a minified bundle before):