Set isSelected to false for formatHolder of list item (#2540)

* Fix 262677: Allow insert entity to a specified position without changing selection * Set isSelected to false for formatHolder of list item
microsoft · Mar 28, 2024 · b806329 · b806329
1 parent c0198f4
commit b806329
Show file tree

Hide file tree

Showing 36 changed files with 399 additions and 395 deletions.
diff --git a/demo/scripts/controlsV2/sidePane/presets/allPresets/listPresets.ts b/demo/scripts/controlsV2/sidePane/presets/allPresets/listPresets.ts
@@ -35,7 +35,7 @@ export const simpleList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -78,7 +78,7 @@ export const simpleList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -130,7 +130,7 @@ export const simpleList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -191,7 +191,7 @@ export const simpleList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -266,7 +266,7 @@ export const simpleList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -307,7 +307,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -346,7 +346,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -385,7 +385,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -424,7 +424,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -472,7 +472,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -520,7 +520,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -568,7 +568,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -625,7 +625,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -682,7 +682,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -739,7 +739,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -769,7 +769,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -808,7 +808,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -856,7 +856,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -904,7 +904,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -943,7 +943,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},
@@ -973,7 +973,7 @@ export const numberedList: Preset = {
                 ],
                 formatHolder: {
                     segmentType: 'SelectionMarker',
-                    isSelected: true,
+                    isSelected: false,
                     format: {},
                 },
                 format: {},

diff --git a/packages/roosterjs-content-model-api/test/modelApi/block/setModelAlignmentTest.ts b/packages/roosterjs-content-model-api/test/modelApi/block/setModelAlignmentTest.ts
@@ -191,7 +191,7 @@ describe('align left', () => {
                     blocks: [para1, para2, para3],
                     formatHolder: {
                         segmentType: 'SelectionMarker',
-                        isSelected: true,
+                        isSelected: false,
                         format: {},
                     },
                     format: {
@@ -254,7 +254,7 @@ describe('align left', () => {
                     blocks: [para1, para2, para3],
                     formatHolder: {
                         segmentType: 'SelectionMarker',
-                        isSelected: true,
+                        isSelected: false,
                         format: {},
                     },
                     format: {
@@ -369,7 +369,7 @@ describe('align left', () => {
                     blocks: [para1, para2, para3],
                     formatHolder: {
                         segmentType: 'SelectionMarker',
-                        isSelected: true,
+                        isSelected: false,
                         format: {},
                     },
                     format: { textAlign: 'center' },
@@ -482,7 +482,7 @@ describe('align left', () => {
                     blocks: [para1, para2, para3],
                     formatHolder: {
                         segmentType: 'SelectionMarker',
-                        isSelected: true,
+                        isSelected: false,
                         format: {},
                     },
                     format: { textAlign: 'end' },
@@ -597,7 +597,7 @@ describe('align left', () => {
                     blocks: [para1, para2, para3],
                     formatHolder: {
                         segmentType: 'SelectionMarker',
-                        isSelected: true,
+                        isSelected: false,
                         format: {},
                     },
                     format: {
@@ -717,7 +717,7 @@ describe('align left', () => {
                     blocks: [para1, para2, para3],
                     formatHolder: {
                         segmentType: 'SelectionMarker',
-                        isSelected: true,
+                        isSelected: false,
                         format: {},
                     },
                     format: {
@@ -838,7 +838,7 @@ describe('align left', () => {
                     blocks: [para1, para2, para3],
                     formatHolder: {
                         segmentType: 'SelectionMarker',
-                        isSelected: true,
+                        isSelected: false,
                         format: {},
                     },
                     format: {
@@ -964,7 +964,7 @@ describe('align left', () => {
                     blocks: [para, para2],
                     formatHolder: {
                         segmentType: 'SelectionMarker',
-                        isSelected: true,
+                        isSelected: false,
                         format: {},
                     },
                     format: { textAlign: 'justify' },

diff --git a/packages/roosterjs-content-model-api/test/modelApi/block/setModelDirectionTest.ts b/packages/roosterjs-content-model-api/test/modelApi/block/setModelDirectionTest.ts
@@ -113,7 +113,7 @@ describe('setModelDirection', () => {
                         formatHolder: {
                             segmentType: 'SelectionMarker',
                             format: {},
-                            isSelected: true,
+                            isSelected: false,
                         },
                         levels: [
                             {
@@ -142,7 +142,7 @@ describe('setModelDirection', () => {
                         formatHolder: {
                             segmentType: 'SelectionMarker',
                             format: {},
-                            isSelected: true,
+                            isSelected: false,
                         },
                         levels: [
                             {
@@ -178,7 +178,7 @@ describe('setModelDirection', () => {
                         formatHolder: {
                             segmentType: 'SelectionMarker',
                             format: {},
-                            isSelected: true,
+                            isSelected: false,
                         },
                         levels: [
                             {
@@ -209,7 +209,7 @@ describe('setModelDirection', () => {
                         formatHolder: {
                             segmentType: 'SelectionMarker',
                             format: {},
-                            isSelected: true,
+                            isSelected: false,
                         },
                         levels: [
                             {

diff --git a/packages/roosterjs-content-model-api/test/modelApi/block/setModelIndentationTest.ts b/packages/roosterjs-content-model-api/test/modelApi/block/setModelIndentationTest.ts
@@ -293,7 +293,7 @@ describe('indent', () => {
                         },
                     ],
                     blocks: [para1, para2, para3],
-                    formatHolder: { segmentType: 'SelectionMarker', isSelected: true, format: {} },
+                    formatHolder: { segmentType: 'SelectionMarker', isSelected: false, format: {} },
                     format: {},
                 },
             ],
@@ -355,7 +355,7 @@ describe('indent', () => {
                         },
                     ],
                     blocks: [para1, para2, para3],
-                    formatHolder: { segmentType: 'SelectionMarker', isSelected: true, format: {} },
+                    formatHolder: { segmentType: 'SelectionMarker', isSelected: false, format: {} },
                     format: {},
                 },
             ],
@@ -397,7 +397,7 @@ describe('indent', () => {
                         },
                     ],
                     blocks: [para2],
-                    formatHolder: { segmentType: 'SelectionMarker', isSelected: true, format: {} },
+                    formatHolder: { segmentType: 'SelectionMarker', isSelected: false, format: {} },
                     format: {},
                 },
                 listItem3,
@@ -450,7 +450,7 @@ describe('indent', () => {
                         },
                     ],
                     blocks: [para1, para2],
-                    formatHolder: { segmentType: 'SelectionMarker', isSelected: true, format: {} },
+                    formatHolder: { segmentType: 'SelectionMarker', isSelected: false, format: {} },
                     format: {},
                 },
                 {
@@ -465,7 +465,7 @@ describe('indent', () => {
                         },
                     ],
                     blocks: [para3],
-                    formatHolder: { segmentType: 'SelectionMarker', isSelected: true, format: {} },
+                    formatHolder: { segmentType: 'SelectionMarker', isSelected: false, format: {} },
                     format: {},
                 },
             ],
@@ -517,7 +517,7 @@ describe('indent', () => {
                         },
                     ],
                     blocks: [para1, para2],
-                    formatHolder: { segmentType: 'SelectionMarker', isSelected: true, format: {} },
+                    formatHolder: { segmentType: 'SelectionMarker', isSelected: false, format: {} },
                     format: {},
                 },
                 {
@@ -533,7 +533,7 @@ describe('indent', () => {
                         },
                     ],
                     blocks: [para3],
-                    formatHolder: { segmentType: 'SelectionMarker', isSelected: true, format: {} },
+                    formatHolder: { segmentType: 'SelectionMarker', isSelected: false, format: {} },
                     format: {},
                 },
             ],
@@ -586,7 +586,7 @@ describe('indent', () => {
                         },
                     ],
                     blocks: [para1],
-                    formatHolder: { segmentType: 'SelectionMarker', isSelected: true, format: {} },
+                    formatHolder: { segmentType: 'SelectionMarker', isSelected: false, format: {} },
                     format: {},
                 },
                 {
@@ -602,7 +602,7 @@ describe('indent', () => {
                         },
                     ],
                     blocks: [para2],
-                    formatHolder: { segmentType: 'SelectionMarker', isSelected: true, format: {} },
+                    formatHolder: { segmentType: 'SelectionMarker', isSelected: false, format: {} },
                     format: {},
                 },
                 {

diff --git a/packages/roosterjs-content-model-api/test/modelApi/block/toggleModelBlockQuoteTest.ts b/packages/roosterjs-content-model-api/test/modelApi/block/toggleModelBlockQuoteTest.ts
@@ -635,7 +635,7 @@ describe('toggleModelBlockQuote', () => {
                             levels: [],
                             formatHolder: {
                                 segmentType: 'SelectionMarker',
-                                isSelected: true,
+                                isSelected: false,
                                 format: {},
                             },
                             format: {},
@@ -693,7 +693,7 @@ describe('toggleModelBlockQuote', () => {
                     levels: [],
                     formatHolder: {
                         segmentType: 'SelectionMarker',
-                        isSelected: true,
+                        isSelected: false,
                         format: {},
                     },
                     format: {},