Refactor Markdown and Autoformat plugins to use formatTextSegmentBeforeSelectionMarker #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rosoft/roosterjs into u/juliaroldi/auto-hypen-port
…rosoft/roosterjs into u/juliaroldi/auto-hypen-port
JiuqingSong
approved these changes
Apr 4, 2024
|
Great to see code become much shorter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoFormat plugin is responsible for formatting two dashes into a hyphen. This feature was ported into content model AutoFormatPlugin.
Refactor the
setFormat,transformHyphen,keyboardListTrigger,createLinkAfterSpace,createLinkandunlinkfunctions to useformatTextSegmentBeforeSelectionMarkerfunction. This function is a common code between all the refactored functions. It is responsible for get the segment before the selection marker and make changes to it.The
getLinkSegmentwas removed, since it is not necessary anymore.