-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content Model cache improvement: Let Content model update cache for child list change #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
changed the title
Perf step 2: Let Content model update cache for child list change
Content Model cache improvement: Let Content model update cache for child list change
Jun 10, 2024
JiuqingSong
requested review from
flyingbee2012,
ianeli1,
vinguyen12,
juliaroldi and
Andres-CT98
June 10, 2024 23:13
BryanValverdeU
approved these changes
Jun 12, 2024
BryanValverdeU
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of cache improvement, when user type in a new line, browser will change the HTML from
into
This will generate 3 mutations:
BR
nodeIn this change, I'm making
TextMutationObserver
andDomIndexer
to be able to handle these changes without regenerating the whole content model. In general, it will first check if the mutations can be handled, then let domIndexer add/remove/modify existing content model to reflect these mutations:BR
node => Remove existing ContentModelBrNow with this change, in most normal editing operations, we don't need to regenerate content model. The remaining ones are move about entity. We will handle them later.