Revert Shortcut command for Clear Format on mac #2834
Conversation
|
@juliaroldi would you please comment here? |
@juliaroldi Sorry for late response, busy last week. I don't think keystroke conflicts are a concern for this PR, and it's not just a problem with this shortcut, ShortcutPlugin should take care of additional keystroke triggers. On the other hand, emoji panel is using the browser shortcut, which has highest priority in browser(like the spotlight in system). |
Hi @miku1958, with the current implementation of the ShortcutPlugin, the meta + control + space will not trigger the emoji panel. Could please test this scenario on your branch? I did the test in Chrome Browser. |
|
@juliaroldi I do some tests and make some fix, please review it again thanks. |
miku1958
force-pushed
the
revert-⌘-space
branch
from
55f5f6a to
99c0e67
Compare
|
@miku1958 For some unknown reason the required check "license/cla" is not running. This happened before and it seems like a github issue. I don't have a way to manually trigger it. So to workaround, you can try to push some change again (say modify a comment, or any minor change), to trigger it. Thanks. |
|
@JiuqingSong it works now |
* fix test * test * Merge text node and segments (#2846) * Merge text segments * Fix test * merge node * fix build and test * add test * Add test * fix test * Remove tablePreProcessor (#2849) * Add change data and apiName to ContentChangedEvent when handle keyboard input (#2854) * Fix #2857 (#2858) * Revert Shortcut command for Clear Format on mac (#2834) * revert Shortcut command for Clear Format on mac * fix ctrl and meta can press in the same time * update comment * Allow browser's default paste behavior when pasting from Office Android (#2863) * Implement shouldPreventDefaultPaste function * fix build * fix build * list-bugs * fix image floating * Customize the behavior of merging format values (#2865) * define types * add callbacks * use param instead * fix test --------- Co-authored-by: Jiuqing Song <jisong@microsoft.com> * updateVersion.json * Fix merge segment issue (#2871) --------- Co-authored-by: Julia Roldi (from Dev Box) <juliaroldi@microsoft.com> Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com> Co-authored-by: Jiuqing Song <jisong@microsoft.com> Co-authored-by: 庄黛淳华 <miku1958@users.noreply.github.com> Co-authored-by: Rain-Zheng <67583056+Rain-Zheng@users.noreply.github.com>
This shortcut is the same as the default global spotlight shortcut, so it is invalid if the user keeps spotlight‘s. Some users prefer to keep it the same as Windows by disable spotlight