Fix #2857 #2858
Merged
Fix #2857 #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiuqingSong
requested review from
flyingbee2012,
BryanValverdeU,
ianeli1,
vinguyen12 and
juliaroldi
juliaroldi
approved these changes
Nov 4, 2024
BryanValverdeU
added a commit
that referenced
this pull request
Nov 15, 2024
* fix test * test * Merge text node and segments (#2846) * Merge text segments * Fix test * merge node * fix build and test * add test * Add test * fix test * Remove tablePreProcessor (#2849) * Add change data and apiName to ContentChangedEvent when handle keyboard input (#2854) * Fix #2857 (#2858) * Revert Shortcut command for Clear Format on mac (#2834) * revert Shortcut command for Clear Format on mac * fix ctrl and meta can press in the same time * update comment * Allow browser's default paste behavior when pasting from Office Android (#2863) * Implement shouldPreventDefaultPaste function * fix build * fix build * list-bugs * fix image floating * Customize the behavior of merging format values (#2865) * define types * add callbacks * use param instead * fix test --------- Co-authored-by: Jiuqing Song <jisong@microsoft.com> * updateVersion.json * Fix merge segment issue (#2871) --------- Co-authored-by: Julia Roldi (from Dev Box) <juliaroldi@microsoft.com> Co-authored-by: Julia Roldi <87443959+juliaroldi@users.noreply.github.com> Co-authored-by: Jiuqing Song <jisong@microsoft.com> Co-authored-by: 庄黛淳华 <miku1958@users.noreply.github.com> Co-authored-by: Rain-Zheng <67583056+Rain-Zheng@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2857
Bold style is missing when ENTER on list item
This is because when create new list item, instead of inheriting list item format from previous list item, we actually inherit format from current selection marker, that causes bold format is incorrectly set into list item format holder, which causes when recreate the new list item, it thoughts there is already bold format applied in container level, so bold format is skipped.
Fix: Inherit format from previous list item instead.