Enable some new test assemblies to be friends #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Microsoft.ServiceFabric.Actors.KVSToRCMigration/Friend.cs
pakunapamsft
approved these changes
Apr 9, 2024
|
Thanks @ChrisBurgessMS. Could you update the PR description to explain what is being changed and why? |
ChrisBurgessMS
changed the title
The what is within the PR. The why has been added to the description. |
olegsych
reviewed
Apr 9, 2024
…oft_ServiceFabric_Services_Friends
olegsych
approved these changes
Apr 9, 2024
olegsych
deleted the
user/chrisburgessm/release_6.1/Microsoft_ServiceFabric_Services_Friends
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing of Service Fabric requires the ability to reach into this assembly and use internal classes. There are new binaries that need access to this assembly's internals so the assembly needs new entries to make those internal accessible.