Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable some new test assemblies to be friends #367

Conversation

ChrisBurgessMS
Copy link
Contributor

@ChrisBurgessMS ChrisBurgessMS commented Apr 9, 2024

Testing of Service Fabric requires the ability to reach into this assembly and use internal classes. There are new binaries that need access to this assembly's internals so the assembly needs new entries to make those internal accessible.

# Conflicts:
#	src/Microsoft.ServiceFabric.Actors.KVSToRCMigration/Friend.cs

# Conflicts:
#	src/Microsoft.ServiceFabric.Actors.KVSToRCMigration/Friend.cs
@ChrisBurgessMS ChrisBurgessMS reopened this Apr 9, 2024
@ChrisBurgessMS ChrisBurgessMS changed the base branch from develop to release_7.1 April 9, 2024 16:34
@olegsych
Copy link
Member

olegsych commented Apr 9, 2024

For some reason the build isn't getting triggered like it did for the release_7.0 PR. I'll try to close and reopen the PR.

@olegsych olegsych closed this Apr 9, 2024
@olegsych olegsych reopened this Apr 9, 2024
@olegsych olegsych self-assigned this Apr 9, 2024
@ChrisBurgessMS ChrisBurgessMS merged commit 4164418 into release_7.1 Apr 9, 2024
2 checks passed
@olegsych olegsych deleted the user/chrisburgessm/release_7.1/Microsoft_ServiceFabric_Services_Friends branch June 19, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants