Remove state Actor migration support #375
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegsych
force-pushed
the
user/olegsych/RemoveKvsToRcMigration
branch
from
96c4731
to
8fa45ee
Compare
The KVS to RC migration projects were created years ago based on the direction from the Service Fabric Data team, who didn't want to support automatic migration. Since then, the strategy has changed and the migration effort was abandoned and these projects haven't been maintained. In addition, to being abandoned, these projects have a dependency on the unsafe packages, such as Newtonsoft.Json, which are now reported by the component governance. Since there is no plan to resume this effort, the abandoned code is removed. Remove migration projects
Types in this namespace were created to support the abandoned KVS to RC state migration effort.
olegsych
force-pushed
the
user/olegsych/RemoveKvsToRcMigration
branch
from
8fa45ee
to
154af8b
Compare
olegsych
changed the title
|
@pakunapamsft what do you think about removing the KVS to RC migration code from this repo? Since this effort was abandoned and now has been flagged by the component governance, I thought it would make more sense to remove it rather than maintain it. When I started this experiment, I didn't realize that we also have public API in the |
pakunapamsft
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KVS to RC migration projects were created years ago based on the direction from the Service Fabric Data team, who didn't want to support automatic migration. Since then, the strategy has changed, the migration effort was abandoned and these projects haven't been maintained.
In addition, to being abandoned, these projects have a dependency on the unsafe packages, such as Newtonsoft.Json, which are now reported by the component governance. Since there is no plan to resume this effort, the abandoned code is removed.