Updating the build doc #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello snmalloc developers. I was going through the build in my project and saw a couple of things that might need updating.
First, it looks like Visual Studio 15 aligns with 2017, not 2019.
It appears this style of generator name "Visual Studio 15 2019 Win64" are for compatibility with CMake versions before 3.1 which was around 2014. In modern CMake, the Visual Studio generator is specified like so:
cmake -G "Visual Studio 15 2017" -A Win32
cmake -G "Visual Studio 15 2017" -A x64
cmake -G "Visual Studio 15 2017" -A ARM
cmake -G "Visual Studio 15 2017" -A ARM64
Since you mention VS 2022 being used in CI regularly, it seems like that should be the generator used in the doc.
The path to malloc.cc and new.cc seem incorrect. Maybe it changed overtime and wasn't updated in the doc.