Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proxy](7/n) self vendor array and algorithm headers #722

Merged
merged 6 commits into from
Jan 9, 2025
Merged

[proxy](7/n) self vendor array and algorithm headers #722

merged 6 commits into from
Jan 9, 2025

Conversation

SchrodingerZhu
Copy link
Collaborator

@SchrodingerZhu SchrodingerZhu commented Dec 21, 2024 •
edited
Loading

This patch clears all STL dependency in the core header library.
Stacked on #721

@SchrodingerZhu SchrodingerZhu force-pushed the proxy-array branch 5 times, most recently from 97b2d9a to 2b26c85 Compare December 21, 2024 23:22
@SchrodingerZhu SchrodingerZhu changed the title [proxy](7/n) proxy array headers [proxy](7/n) proxy array and algorithm headers Dec 21, 2024
@SchrodingerZhu SchrodingerZhu force-pushed the proxy-array branch 3 times, most recently from 31ede07 to d6b807f Compare December 22, 2024 05:43
mjp41
mjp41 reviewed Jan 2, 2025
View reviewed changes
src/snmalloc/proxy/algorithm.h Outdated Show resolved Hide resolved
src/snmalloc/global/memcpy.h Outdated Show resolved Hide resolved
mjp41
mjp41 reviewed Jan 9, 2025
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@SchrodingerZhu SchrodingerZhu requested a review from mjp41 January 9, 2025 12:28
@SchrodingerZhu SchrodingerZhu changed the title [proxy](7/n) proxy array and algorithm headers [proxy](7/n) self vendor array and algorithm headers Jan 9, 2025
mjp41
mjp41 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this.

@mjp41 mjp41 merged commit 0111a41 into microsoft:main Jan 9, 2025
62 checks passed
@SchrodingerZhu SchrodingerZhu mentioned this pull request Jan 9, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjp41 mjp41 mjp41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SchrodingerZhu @mjp41