-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pal_windows.h: missing <cerrno> for ENOMEM on MinGW #733
Conversation
@SchrodingerZhu, is this an area where we are missing stuff for freestanding? |
We don't really support MinGW in freestanding so the change is fine to me. However, it is a bit inconsistent that we include cxx header for mingw targets. |
hmm why ? it's C++ code, the valid header to include is the <c....> cxx version, not the C .h version and both GCC and Clang as shipped by mingw become more strict with this over time |
Just for some context. @SchrodingerZhu has been working on getting snmalloc as a built-in option in the LLVM libc. To do that, they have removed a bunch of dependencies on the C++ header files. This is mostly a refactoring. My comment was mostly "@SchrodingerZhu I think you missed a bit." rather than a comment about your change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this.
ahh thanks for the context, makes more sense! |
Co-authored-by: Matthew Parkinson <mjp41@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.