Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DacFx version to 162.1.124-preview #2170

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Update DacFx version to 162.1.124-preview #2170

merged 2 commits into from
Aug 24, 2023

Conversation

zijchen
Copy link
Member

@zijchen zijchen commented Aug 15, 2023

No description provided.

@github-actions
Copy link

As part of updating the dependencies in Packages.props we require that any PRs opened also verify that
they've done the following checks.

Please respond to this comment verifying that you've done the appropriate validation (or explain why it's not necessary) before merging in the PR

  • Built and tested the change locally to validate that the update doesn't cause any regressions and fixes the issues intended
  • Tested changes on all major platforms
    • Windows
    • Linux
    • Mac
  • Check the source repo for any open issues with the release being updated to (if available)

@Charles-Gagnon
Copy link
Contributor

Looks like a DeployWithOptions test failure that seems related

@zijchen zijchen changed the title Update DacFx version to 162.1.112-preview Update DacFx version to 162.1.124-preview Aug 24, 2023
@zijchen
Copy link
Member Author

zijchen commented Aug 24, 2023

Looks like a DeployWithOptions test failure that seems related

Yeah thanks for the heads up, it uncovered a regression that only showed up in the release build. Fixed and updated to latest.

@zijchen zijchen merged commit 6be15ce into main Aug 24, 2023
6 checks passed
@zijchen zijchen deleted the zijchen-patch-2 branch August 24, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants