Fix session restoration of full buffers #17654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
reviewed
Aug 2, 2024
|
Oh, good point. I should not move the viewport but rather print newlines and then CUP up. Edit: No wait, we can't, because once we persist the buffer accurately, including trailing whitespace, those newlines will also get persisted. It must be viewport panning! Hmmmm... Perhaps we have to change the renderer to support out of bounds viewports. But that may be a future improvement. |
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
|
We talked about it and decided to just show as much scrollback as possible, since the popups in cmd now use VT. |
microsoft-github-policy-service
bot
added
Needs-Attention
lhecker
force-pushed
the
dev/lhecker/17639-restore-viewport
branch
from
0d78d84
to
e7527ac
Compare
lhecker
commented
Aug 9, 2024
| { | ||
| _terminal->Write(L"\r\n"); | ||
| } | ||
| _terminal->Write(message); |
There was a problem hiding this comment.
Moving it into the loop allows us to reuse the console lock that we've already acquired.
DHowett
approved these changes
Aug 9, 2024
carlos-zamora
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
Terminal::SetViewportPositioncall from sessionrestoration which was responsible for putting the viewport below
the buffer height and caused the renderer to fail.
In order to prevent such issues in the future,
SetViewportPositionnow protects itself against out of bounds requests.
Closes #17639
Validation Steps Performed
big.txt