Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'configurable: true' to descriptors in __createBinding and __setModuleDefault #247

Closed
wants to merge 1 commit into from

Conversation

rbuckton
Copy link
Member

This is the companion PR to microsoft/TypeScript#57784 which improves compatibility with Jest's module mocking mechanism.

@rbuckton
Copy link
Member Author

rbuckton commented Apr 2, 2024

Following discussion in the Design Meeting, we've decided not to take this fix as we would be inconsistent with esbuild, babel, et al. There are already workarounds for this, such as using jest.unstable_moduleMock, and this seems like an issue Jest would need to address in their mock implementation so as to be compatible with other transpilers, such as replacing the module object, introducing a Proxy, etc.

@rbuckton rbuckton closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant