Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ignition-fuel-tools4] Add new port 🤖 #15581

Merged
merged 2 commits into from
Jan 17, 2021

Conversation

traversaro
Copy link
Contributor

  • What does your PR fix?

  • Which triplets are supported/not supported?

    • All tested triplet (for which the dependency are actually available) should be supported.
  • Does your PR follow the maintainer guide?

    • I hope.

As discussed in #7781, different major version of ignition robotics libraries (https://ignitionrobotics.org/) can be installed side by side, so each new major version is added as a new port.

In particular, ignition-fuel-tools4 is a dependency for Gazebo 11 (http://gazebosim.org/blog/gazebo11) and for Ignition Robotics Citadel (that contains Ignition Gazebo 3, see https://www.openrobotics.org/blog/2019/12/11/ignition-citadel-released).

@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 12, 2021
@NancyLi1013
Copy link
Contributor

The hash value seems incorrect:

File does not have expected hash:

          File path: [ D:/downloads/temp/ignitionrobotics-ign-fuel-tools-ignition-fuel-tools4_4.3.0.tar.gz ]
      Expected hash: [ a656fed74fb2138b3bcf7d35b25ad06da95cfb9a3ad7ded2c9c54db385f55ea310fd1a72dcf6400b0a6199e376c1ba2d11ee2a08c66e3c2cc8b2ee1b25406986 ]
        Actual hash: [ 451d7bcd195a8ce41c3a7d64ad936c8c0812cbc7af03dbe75cbdc359599bf1f828595833c1758d4de8e37c37730bb852de95b2256ff9134af4ab197df2b66a8b ]

@traversaro traversaro changed the title [ignition-fuel-tools4] Add new port 🤖 [WIP] [ignition-fuel-tools4] Add new port 🤖 Jan 12, 2021
@traversaro
Copy link
Contributor Author

The hash value seems incorrect:

File does not have expected hash:

          File path: [ D:/downloads/temp/ignitionrobotics-ign-fuel-tools-ignition-fuel-tools4_4.3.0.tar.gz ]
      Expected hash: [ a656fed74fb2138b3bcf7d35b25ad06da95cfb9a3ad7ded2c9c54db385f55ea310fd1a72dcf6400b0a6199e376c1ba2d11ee2a08c66e3c2cc8b2ee1b25406986 ]
        Actual hash: [ 451d7bcd195a8ce41c3a7d64ad936c8c0812cbc7af03dbe75cbdc359599bf1f828595833c1758d4de8e37c37730bb852de95b2256ff9134af4ab197df2b66a8b ]

My bad, I fixed it now in 4d9f918 . However, I marked it as WIP as I did not tested it on all the platforms supported by CI.

@traversaro
Copy link
Contributor Author

Linux build is broken by the libzip pkg-config files, that will be fixed by https://github.com/microsoft/vcpkg/pull/15589/files . I had already added the same changes here, so if the CI works we can wait for https://github.com/microsoft/vcpkg/pull/15589/files to be merged and we can rebase.

@NancyLi1013
Copy link
Contributor

@traversaro

PR #15589 has been merged to master now. You might need to revert the changes about libzip in this PR.

@traversaro traversaro changed the title [WIP] [ignition-fuel-tools4] Add new port 🤖 [ignition-fuel-tools4] Add new port 🤖 Jan 15, 2021
@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 15, 2021
@traversaro
Copy link
Contributor Author

Thanks @NancyLi1013 !

@dan-shaw dan-shaw merged commit 3ddaeb4 into microsoft:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants