[azure-security-keyvault-*] Add new ports #17143

azure-sdk · 2021-04-08T00:16:52Z

Update vcpkg ports for Azure SDK release. This release may contain multiple ports.

## 4.0.0-beta.1 (2021-04-07) ### New Features - KeyVaultException.

## 4.0.0-beta.1 (2021-04-07) ### New Features - Added `Azure::Security::KeyVault::Keys::KeyClient` for get, create, list, delete, backup, restore, and import key operations. - Added high-level and simplified `key_vault.hpp` file for simpler include experience for customers. - Added model types which are returned from the `KeyClient` operations, such as `Azure::Security::KeyVault::Keys::KeyVaultKey`.

ahsonkhan · 2021-04-08T00:41:50Z

This new port needs #17142 to go in first since it depends on azure-core-cpp.

versions/baseline.json

autoantwort · 2021-04-08T01:24:55Z

So this should be merged into vcpkg and is not spam?

autoantwort · 2021-04-08T01:32:00Z

From here:

Many existing ports use the CONTROL file syntax; while this syntax will be supported for some time to come, new ports should not use these. Any newly added port must use the manifest files.

You can use vcpkg format-manifest ports/azure-security-keyvault-common-cpp/CONTROL ports/azure-security-keyvault-keys-cpp/CONTROL to convert the files

NancyLi1013 · 2021-04-08T02:26:18Z

ports/azure-security-keyvault-common-cpp/CONTROL

+Build-Depends: azure-core-cpp
+Description: Microsoft Azure Common Key Vault SDK for C++
+  This library provides common Azure KeyVault-related abstractions for Azure SDK.
+Homepage: https://github.com/Azure/azure-sdk-for-cpp/tree/master/sdk/keyvault/azure-security-keyvault-common


As suggested from @autoantwort #17143 (comment), we prefer to use vcpkg.json instead of CONTROL file for new ports. So could you please update this?

@antkmsft and @danieljurek, we need to update our package definition and publish automation process to use the new mechanism. Can you please take a look.

@NancyLi1013 we can't do the update right now. We just invested time into this and wrote automation and integration with our CI/CD a couple of months ago, when the CONTROL file was mainstream. We don't write these files manually. We'll need to upgrade our whole repo, we practically can't do this on an one-off basis by hand. It does not mean we are refusing the upgrade - we'll likely look into this, but if it is not something you mandate, please don't block us. We want to have several beta releases of our SDK in VcPkg to collect customer feedback and smoothen some stories, including VcPkg consumption.

NancyLi1013 · 2021-04-08T02:28:04Z

ports/azure-security-keyvault-common-cpp/portfile.cmake

+    OUT_SOURCE_PATH SOURCE_PATH
+    REPO Azure/azure-sdk-for-cpp
+    REF azure-security-keyvault-common_4.0.0-beta.1
+    SHA512 7364bf775bbf6115bf54ee0c2df8b2bae35ea31c669fcbc358edd00a948f2c73926fbf88282ff5442f40ead9cdfc78661a08e4f86002ac2eac5e78ddd13eb33d


Suggested change

SHA512 7364bf775bbf6115bf54ee0c2df8b2bae35ea31c669fcbc358edd00a948f2c73926fbf88282ff5442f40ead9cdfc78661a08e4f86002ac2eac5e78ddd13eb33d

SHA512 7364bf775bbf6115bf54ee0c2df8b2bae35ea31c669fcbc358edd00a948f2c73926fbf88282ff5442f40ead9cdfc78661a08e4f86002ac2eac5e78ddd13eb33d

HEAD_REF master

Please see the reference here https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_from_github.md#notes

NancyLi1013 · 2021-04-08T02:29:39Z

ports/azure-security-keyvault-keys-cpp/CONTROL

+Build-Depends: azure-security-keyvault-common-cpp
+Description: Microsoft Azure Key Vault Keys SDK for C++
+  This library provides Azure Key Vault Keys SDK.
+Homepage: https://github.com/Azure/azure-sdk-for-cpp/tree/master/sdk/keyvault/azure-security-keyvault-keys


The same as above. vcpkg.json is more preferable for new ports.

This has been addressed.

NancyLi1013 · 2021-04-08T02:31:32Z

ports/azure-security-keyvault-keys-cpp/portfile.cmake

+    OUT_SOURCE_PATH SOURCE_PATH
+    REPO Azure/azure-sdk-for-cpp
+    REF azure-security-keyvault-keys_4.0.0-beta.1
+    SHA512 fb5158320c859f27c97c86908fd4c3f7ceec2ec8b0ca3c213a075992b62dfdefa3a560173bc7034153c273c30abd7fd0a84f98842810de2f78412549e5d34ee4


Suggested change

SHA512 fb5158320c859f27c97c86908fd4c3f7ceec2ec8b0ca3c213a075992b62dfdefa3a560173bc7034153c273c30abd7fd0a84f98842810de2f78412549e5d34ee4

SHA512 fb5158320c859f27c97c86908fd4c3f7ceec2ec8b0ca3c213a075992b62dfdefa3a560173bc7034153c273c30abd7fd0a84f98842810de2f78412549e5d34ee4

HEAD_REF master

Please see https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_from_github.md#notes

@NancyLi1013, we use REF, why do we also need HEAD_REF master? We tag our releases, we don't release from master.

So you only use REF, which is not related with branch. right? If yes, HEAD_REF might not be required.

Yes - we tag releases in master branch and release from there: https://github.com/Azure/azure-sdk-for-cpp/tags

Sorry for my wrong understanding about this. If we add HEAD_REF, will enable support for install --head.
https://github.com/microsoft/vcpkg/blob/master/docs/maintainers/vcpkg_from_github.md#head_ref

So this is an extra feature. Adding it or not are both good.

ahsonkhan · 2021-04-08T03:35:23Z

So this should be merged into vcpkg and is not spam?

Yes, this is intended to be merged. We will no longer open non-draft PRs that are just for tests, and limit even the draft PRs that are open (ideally just one - #17119).

ahsonkhan · 2021-04-08T03:38:55Z

@autoantwort and @NancyLi1013 - are we allowed to change from the CONTROL format to the vcpkg.json format for the existing ports as well, for consistency? We have multiple packages coming from https://github.com/Azure/azure-sdk-for-cpp, some already in the registry and use the CONTROL file syntax (like azure-core-cpp) and some new (like this PR), and we want to avoid maintaining/supporting multiple formats for publishing.

autoantwort · 2021-04-08T11:56:41Z

Yeah, the vcpkg.json format is always preferred, the Control files are only legacy. But you should not create PRs where you only change the format, do it when you do a normal library update :)

ports/azure-security-keyvault-common-cpp/portfile.cmake

ahsonkhan · 2021-04-13T00:36:14Z

FYI @RickWinter

file.

ras0219-msft · 2021-04-16T23:57:58Z

/azp run

azure-pipelines · 2021-04-16T23:58:07Z

Azure Pipelines successfully started running 1 pipeline(s).

--overwrite-version'

ahsonkhan · 2021-04-17T00:06:35Z

@NancyLi1013 and @autoantwort, I have addressed the feedback to use vcpkg manifest json file instead of CONTROL for this package. This PR is ready to be merged.

Thanks!

ahsonkhan · 2021-04-17T00:08:15Z

@ras0219-msft can you please help merge this change. We'd like to get this package published today to complete our April release. Appreciate it.

ahsonkhan · 2021-04-17T00:13:54Z

🎉

[azure-security-keyvault-*] Add new ports (microsoft#17143)

azure-sdk added 2 commits April 8, 2021 00:16

[azure-security-keyvault-common-cpp] Update to 4.0.0-beta.1

2877ce6

## 4.0.0-beta.1 (2021-04-07) ### New Features - KeyVaultException.

ahsonkhan reviewed Apr 8, 2021

View reviewed changes

versions/baseline.json Show resolved Hide resolved

ahsonkhan approved these changes Apr 8, 2021

View reviewed changes

JonLiu1993 assigned NancyLi1013 Apr 8, 2021

NancyLi1013 added category:new-port The issue is requesting a new library to be added; consider making a PR! depends:different-pr This PR or Issue depends on a PR which has been filed labels Apr 8, 2021

NancyLi1013 suggested changes Apr 8, 2021

View reviewed changes

NancyLi1013 added the requires:author-response label Apr 8, 2021

NancyLi1013 changed the title ~~Azure Key Vault Keys SDK Apr Release~~ [azure-security-keyvault-*] Add new ports Apr 8, 2021

vhvb1989 mentioned this pull request Apr 8, 2021

Update VCPKG Control file to manifest Azure/azure-sdk-for-cpp#2085

Closed

NancyLi1013 reviewed Apr 9, 2021

View reviewed changes

ports/azure-security-keyvault-common-cpp/portfile.cmake Show resolved Hide resolved

ahsonkhan mentioned this pull request Apr 13, 2021

The vcpkg portfile.cmake should be updated to avoid using deprecated functions Azure/azure-sdk-for-cpp#2107

Closed

Update vcpkg ports to use a manifest json file instead of a CONTROL

db5870b

file.

ahsonkhan mentioned this pull request Apr 16, 2021

Update vcpkg ports to use a manifest json file instead of a CONTROL file. Azure/azure-sdk-for-cpp#2132

Merged

Update git tree sha versions using the command 'x-add-version --all

f5cf831

--overwrite-version'

ras0219-msft merged commit 414bec0 into microsoft:master Apr 17, 2021

ahsonkhan deleted the azure-keyvault-keys-sdk-for-cpp-april-2021 branch April 17, 2021 00:13

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Apr 17, 2021

Merge pull request #593 from microsoft/master

23b1c72

[azure-security-keyvault-*] Add new ports (microsoft#17143)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[azure-security-keyvault-*] Add new ports #17143

[azure-security-keyvault-*] Add new ports #17143

azure-sdk commented Apr 8, 2021

ahsonkhan commented Apr 8, 2021

autoantwort commented Apr 8, 2021

autoantwort commented Apr 8, 2021

NancyLi1013 Apr 8, 2021

ahsonkhan Apr 8, 2021

antkmsft Apr 9, 2021

NancyLi1013 Apr 8, 2021

NancyLi1013 Apr 8, 2021

ahsonkhan Apr 17, 2021

NancyLi1013 Apr 8, 2021

antkmsft Apr 9, 2021

NancyLi1013 Apr 9, 2021

antkmsft Apr 9, 2021

NancyLi1013 Apr 9, 2021

ahsonkhan commented Apr 8, 2021 •

edited

Loading

ahsonkhan commented Apr 8, 2021

autoantwort commented Apr 8, 2021

ahsonkhan commented Apr 13, 2021

ras0219-msft commented Apr 16, 2021

azure-pipelines bot commented Apr 16, 2021

ahsonkhan commented Apr 17, 2021

ahsonkhan commented Apr 17, 2021

ahsonkhan commented Apr 17, 2021

	SHA512 7364bf775bbf6115bf54ee0c2df8b2bae35ea31c669fcbc358edd00a948f2c73926fbf88282ff5442f40ead9cdfc78661a08e4f86002ac2eac5e78ddd13eb33d
	SHA512 7364bf775bbf6115bf54ee0c2df8b2bae35ea31c669fcbc358edd00a948f2c73926fbf88282ff5442f40ead9cdfc78661a08e4f86002ac2eac5e78ddd13eb33d
	HEAD_REF master

	SHA512 fb5158320c859f27c97c86908fd4c3f7ceec2ec8b0ca3c213a075992b62dfdefa3a560173bc7034153c273c30abd7fd0a84f98842810de2f78412549e5d34ee4
	SHA512 fb5158320c859f27c97c86908fd4c3f7ceec2ec8b0ca3c213a075992b62dfdefa3a560173bc7034153c273c30abd7fd0a84f98842810de2f78412549e5d34ee4
	HEAD_REF master

[azure-security-keyvault-*] Add new ports #17143

[azure-security-keyvault-*] Add new ports #17143

Conversation

azure-sdk commented Apr 8, 2021

ahsonkhan commented Apr 8, 2021

autoantwort commented Apr 8, 2021

autoantwort commented Apr 8, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ahsonkhan commented Apr 8, 2021 • edited Loading

ahsonkhan commented Apr 8, 2021

autoantwort commented Apr 8, 2021

ahsonkhan commented Apr 13, 2021

ras0219-msft commented Apr 16, 2021

azure-pipelines bot commented Apr 16, 2021

ahsonkhan commented Apr 17, 2021

ahsonkhan commented Apr 17, 2021

ahsonkhan commented Apr 17, 2021

ahsonkhan commented Apr 8, 2021 •

edited

Loading