Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC|Invalid] Testing vcpkg without installed MSVC #42129

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Nov 12, 2024

Hijacking x64-windows CI for this.

wished somebody would make Visual Studio truly portable. MSBuild looking up all those reg keys is a bit annoying.

No NETFXSDK installed.

Also what are all those different versions about and why don't any of those correlate to the folder version names.

Build system check:

  • cmake
  • autotools
  • meson
  • bazel
  • qmake
  • msbuild (needs ENV{WindowsSDKVersion} fixed) fixed it here

@FrankXie05 FrankXie05 added the requires:testing Needs tests added before merging label Nov 13, 2024
ports/msvc/portfile.cmake Outdated Show resolved Hide resolved
ports/msvc/msvc-env.cmake Outdated Show resolved Hide resolved
@Neumann-A Neumann-A force-pushed the windows-triplet-without-installed-msvc branch from 7538913 to 13f4af9 Compare November 13, 2024 22:55
ports/msvc/vcpkg.json Outdated Show resolved Hide resolved
triplets/x64-windows.cmake Outdated Show resolved Hide resolved
@Neumann-A
Copy link
Contributor Author

Neumann-A commented Nov 17, 2024

Already pretty good:

SUMMARY FOR x64-windows
  SUCCEEDED: 2120
  BUILD_FAILED: 36
  POST_BUILD_CHECKS_FAILED: 10
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 225
SUMMARY FOR x64-windows
  SUCCEEDED: 2144
  BUILD_FAILED: 57
  POST_BUILD_CHECKS_FAILED: 9
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 182

SUMMARY FOR x64-windows
  SUCCEEDED: 2264
  BUILD_FAILED: 35
  POST_BUILD_CHECKS_FAILED: 9
  CASCADED_DUE_TO_MISSING_DEPENDENCIES: 90

@Neumann-A
Copy link
Contributor Author

Neumann-A commented Nov 21, 2024

Fix for using the Visual Studio Generator:

a) Install /VC/Auxiliary/Build/Microsoft.VCToolsVersion.default.txt from the v143 version
b)

   set(CMAKE_GENERATOR_INSTANCE "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/VS/,version=17.12.35410.122" CACHE INTERNAL "")
   set(CMAKE_VS_VERSION_BUILD_NUMBER 17.12.35410.122)

c) list(APPEND CMAKE_TRY_COMPILE_PLATFORM_VARIABLES _VCPKG_INSTALLED_DIR) (for setting CMAKE_GENERATOR_INSTANCE)
d) Update CMake v3.31.0

@Neumann-A
Copy link
Contributor Author

hmm: "-DCMAKE_MAKE_PROGRAM=D:/downloads/tools/ninja/1.10.2-windows/ninja.exe"

@Neumann-A
Copy link
Contributor Author

@dg0yt: Do you have a PR fixing Bazel. I see the error in ryu here:

The target you are compiling requires Visual C++ build tools.
Bazel couldn't find a valid Visual C++ build tools installation on your machine.

Visual C++ build tools seems to be installed at D:\installed\x64-windows\share\msvc\..\..\VS\VC 
But Bazel can't find the following tools: 
    VCVARSALL.BAT, cl.exe, link.exe, lib.exe, ml64.exe 
for x64 target architecture 
 
Please check your installation following https://docs.bazel.build/versions/main/windows.html#using 

and the docs at https://bazel.build/configure/windows#using and think there is still a lot to do for correct bazel support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires:testing Needs tests added before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants