Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gsl-lite] Update to v0.42.0 #42140

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[gsl-lite] Update to v0.42.0 #42140

wants to merge 4 commits into from
+9 −4

Conversation

mbeutel
Copy link
Contributor

@mbeutel mbeutel commented Nov 13, 2024

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Mengna-Li Mengna-Li added the category:port-update The issue is with a library, which is requesting update new revision label Nov 14, 2024
Mengna-Li
Mengna-Li requested changes Nov 14, 2024
View reviewed changes
ports/gsl-lite/portfile.cmake Outdated
@@ -1,8 +1,8 @@
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO gsl-lite/gsl-lite
REF 755ba124b54914e672737acace6a9314f59e8d6f
SHA512 d0b8397afc7704c5c9510fb62ce01f35faf9cc1cfd05ac3853bdc4b9fc4874aaa85aa70e93ff37867dc263b97926b15af2316e49a5787b246984fa086bf85563
REF 004a3e61f30e5c94b5964a0b4a2728847579a304
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
REF 004a3e61f30e5c94b5964a0b4a2728847579a304
REF “v${VERSION}”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without typographic quotation marks, I presume? Just made the change in a new commit.

(I'll note that the version tags references a slightly earlier commit, which is why the SHA has changed; the commits that came after were of peripheral nature and had no impact on the source code.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mengna-Li Mengna-Li Mengna-Li requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Mengna-Li Mengna-Li

Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbeutel @Mengna-Li