-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bw-tempdir] add new port #42342
[bw-tempdir] add new port #42342
Conversation
Usage tested pass on x64-windows. |
As far as I can see, this is not true. Would you be happy if the name of the port was |
Hi, thank you very much for your feedback and the value-able work on the vcpkg project. Preferred name would be "tempdir" and to be honest I can't see an issue with that. There are "tempdir" named packages from python and rust world, so I think "tempdir" for c++ ecosystem wouldn't do any harm? Or do I miss something? All this packages as well as @tempdir from Java attempt to provide the same feature of self cleaning temporary directories. So from my point of view "tempdir" would be the natural fit also for c++. Alternatives I can think of would be in order of preference:
Please advice if renaming is really required and in case it is, which version you would accept. Thanks |
There is no objection to your library being named Our concern is that once we have 'given away' a name, we can never change it to something else. That is, |
Ok, understand. Would you accept "bw-tempdir" as I like it more because it is shorter and resembles the namespace/include path |
Renamed the port from "tempdir" to "bw-tempdir" hope this is fine. |
@ras0219-msft @vicroms and I think |
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.