Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Update config classes to match old configurations #26

Merged
merged 3 commits into from
Aug 1, 2024
Merged

[Bugfix] Update config classes to match old configurations #26

merged 3 commits into from
Aug 1, 2024

Conversation

anmolagarwalcp810
Copy link
Contributor

@anmolagarwalcp810 anmolagarwalcp810 commented Aug 1, 2024 •
edited
Loading

Some config classes had properties not matching with old properties, and there were some conflicting types of config classes. All of these issues have now been fixed.

Changes made:

  1. Update types to correct value for A40 and A100 device configs.
  2. Update rope_theta and max_position_embeddings values for different model configs.
  3. Added model config for internlm/internlm-20b.
  4. Update num_devices_per_node for A100/H100 pairewise nvlink.

@AgrawalAmey AgrawalAmey merged commit 86e0a99 into microsoft:main Aug 1, 2024
2 checks passed
Hanchenli pushed a commit to XbzOnGit/vidur that referenced this pull request Nov 8, 2024
@anmolagarwalcp810 @AgrawalAmey
[Bugfix] Update config classes to match old configurations (microsoft#26
a6e5333 
)

* Config updates for device, model and node

* Optional[float] for rope theta

---------

Co-authored-by: Amey Agrawal <agrawalamey12@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgrawalAmey AgrawalAmey AgrawalAmey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmolagarwalcp810 @AgrawalAmey